Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tvOS target #800

Closed
wants to merge 1 commit into from
Closed

Create tvOS target #800

wants to merge 1 commit into from

Conversation

cmcewen
Copy link
Contributor

@cmcewen cmcewen commented Apr 18, 2017

This creates a tvOS target - I haven't tested but at the very least it prevents JS errors when running on tvOS that come from not having the native module included in the project.

@msftclas
Copy link

@cmcewen, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@max-mironov
Copy link
Contributor

@cmcewen - thanks for contribution. I've tried to apply your PR and then build it in xCode with blank RN app but I've got the following errors:
image
Could you please have a look at this and guide me if I'm missing something?

@sergey-akhalkov
Copy link
Contributor

Hi @cmcewen, thanks for the contribution! Currently, we are experiencing some issues with this, so could you please have a chance to look at the exception @max-mironov have sent above?
Could you please also confirm this PR #824 has the same improvements as yours?

@max-mironov
Copy link
Contributor

@cmcewen we believe that both - your PR and #824 serves the same goal but the latter also has support for podspecs, so if you don't mind we'll close this one to avoid duplication. Please let us know if you have any concerns or you have any suggestions.

@max-mironov max-mironov closed this Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants