Fixed issue with [Android] restartApp() throwing exception w/ release build #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 17, 2017 16:16
sergey-akhalkov
approved these changes
May 26, 2017
…tring In accordance with docs and microsoft#862
AndrewJack
reviewed
May 30, 2017
| @@ -108,7 +108,9 @@ private void setJSBundle(ReactInstanceManager instanceManager, String latestJSBu | |||
|
|
|||
| Method[] methods = jsBundleLoaderClass.getDeclaredMethods(); | |||
| for (Method method : methods) { | |||
| if (method.getName().equals("createFileLoader")) { | |||
| String createFileLoaderMethodName = latestJSBundleFile.toLowerCase().startsWith("assets://") | |||
| ? "createAssetLoader" : "createFileLoader"; | |||
There was a problem hiding this comment.
Avoid assigning inside the loop.
There was a problem hiding this comment.
@AndrewJack - thanks for pointing at this, added commit to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#847