[WPF] Fix application crash when storage file was deleted while app is being active. #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abodalevsky
commented
Jun 21, 2017
| @@ -1,9 +0,0 @@ | |||
| <?xml version="1.0" encoding="utf-8" standalone="no"?> | |||
There was a problem hiding this comment.
this file should be created by Visual Studio dynamically
|
Hi @abodalevsky, thanks for the contribution, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If by some reason persistent storage file was deleted while application is running, next time when CodePush tries to access it it crashes with the following exception:
System.IO.FileNotFoundException: Could not find file 'C:\Users\USER_NAME\AppData\Local\PATH_TO_APP\CodePush\CodePush'.The fix is, if file was deleted - recreate the storage file. Of course all settings will be lost when file was deleted.