-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the debug message for missing bundles #923
Conversation
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
@cooperka - thank you, looks good for me and we appreciate your help with this! |
Closing for now, thanks! |
@cooperka seems that latest RN48 introduced this changes so we can merge this PR going further |
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Thanks for the update @max-mironov! Fyi the RN PR was modified to change the name of the flag, so I will modify the text here before we merge. It'll be a few hours before I can get to it. |
Thanks for taking care of it @cooperka |
f938661
to
a583f83
Compare
a583f83
to
6690171
Compare
@max-mironov done! |
Thanks, merging this! |
Note: The PR this references isn't merged yet. I'd rather create this PR now than possibly forget about it in the future.Update the debug message in
CodePush.m
for missing bundles, due to the upcoming change in facebook/react-native#14731.The default behavior will be to skip bundling entirely for all Debug builds, rather than just Debug builds for the Simulator.The bundling behavior can be controlled using the newFORCE_BUNDLING
flag.