Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the debug message for missing bundles #923

Merged
merged 3 commits into from
Sep 7, 2017

Conversation

cooperka
Copy link
Contributor

@cooperka cooperka commented Jul 17, 2017

Note: The PR this references isn't merged yet. I'd rather create this PR now than possibly forget about it in the future.

Update the debug message in CodePush.m for missing bundles, due to the upcoming change in facebook/react-native#14731.

The default behavior will be to skip bundling entirely for all Debug builds, rather than just Debug builds for the Simulator. The bundling behavior can be controlled using the new FORCE_BUNDLING flag.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@max-mironov
Copy link
Contributor

@cooperka - thank you, looks good for me and we appreciate your help with this!
This PR would be merged once RN released new version containing referenced changes.

@cooperka
Copy link
Contributor Author

cooperka commented Jul 17, 2017

Closing for now, thanks!

@cooperka cooperka closed this Jul 17, 2017
@max-mironov
Copy link
Contributor

@cooperka seems that latest RN48 introduced this changes so we can merge this PR going further

@max-mironov max-mironov reopened this Sep 7, 2017
@msftclas
Copy link

msftclas commented Sep 7, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@cooperka
Copy link
Contributor Author

cooperka commented Sep 7, 2017

Thanks for the update @max-mironov! Fyi the RN PR was modified to change the name of the flag, so I will modify the text here before we merge. It'll be a few hours before I can get to it.

@max-mironov
Copy link
Contributor

Thanks for taking care of it @cooperka

@cooperka
Copy link
Contributor Author

cooperka commented Sep 7, 2017

@max-mironov done!

@max-mironov
Copy link
Contributor

Thanks, merging this!

@max-mironov max-mironov merged commit 359ab98 into microsoft:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants