Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled a Scaled Back Permissions Page #121

Closed
chiaramooney opened this issue Apr 22, 2021 · 2 comments · Fixed by #151
Closed

Enabled a Scaled Back Permissions Page #121

chiaramooney opened this issue Apr 22, 2021 · 2 comments · Fixed by #151
Labels
bug Something isn't working
Milestone

Comments

@chiaramooney
Copy link
Contributor

Currently the permissions page seeks to request almost every permission possible. This causes the app’s appxmanifest to have a ton of capabilities, more than seem necessary. Look into reducing the scope of the permissions that the permissions page is trying to seek. Look into temporarily remove the permissions page entirely.

@ghost ghost added the Needs: triage 🔍 label Apr 22, 2021
@chiaramooney chiaramooney added bug Something isn't working and removed Needs: triage 🔍 labels Apr 22, 2021
@stmoy
Copy link

stmoy commented Apr 22, 2021

CC: @tritao - @chiaramooney, the purpose of the Permissions module is to enable the app to request almost every permission possible. However, this has the side effect of exploding the appxmanifest such that it looks like the Gallery needs all of these permissions.

I wonder if the permissions page itself should list all of the permissions it can support, but the app itself doesn't actually request any more than needed? What is the minimum set of permissions required?

@chiaramooney
Copy link
Contributor Author

@stmoy The minimum capabilities for an RNW app is InternetClient and that's it.

Temporary Removal of Permissions Page: #124

@chiaramooney chiaramooney changed the title Scale Back / Disable Permissions Page Enabled a Scaled Back Permissions Page Apr 28, 2021
@chiaramooney chiaramooney added this to the Backlog milestone May 6, 2021
tritao added a commit to JaneaSystems/react-native-gallery that referenced this issue Jun 28, 2021
tritao added a commit to JaneaSystems/react-native-gallery that referenced this issue Jun 28, 2021
tritao added a commit to JaneaSystems/react-native-gallery that referenced this issue Jun 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants