Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 10 Compatibility page shouldn't need to be versioned #830

Closed
jonthysell opened this issue Apr 18, 2023 · 1 comment · Fixed by #836
Closed

Windows 10 Compatibility page shouldn't need to be versioned #830

jonthysell opened this issue Apr 18, 2023 · 1 comment · Fixed by #836
Assignees
@chiaramooney
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
0.72

Comments

@jonthysell
Copy link
Contributor

Page url

https://microsoft.github.io/react-native-windows/docs/win10-compat

Problem Description

Since this page is mostly a table that is constantly updated with the ranges of Win10 min/target versions for ranges of RNW versions, this page should be treated as "static" and cleaned up.1

  1. The latest version in docs should be double-checked as being accurate
  2. The oldest version in versioned_docs should be replaced with the one from docs
  3. All old versions inbetween should be deleted.

This will ensure that the page is the same no matter which version of the docs is being looked at.
@jonthysell jonthysell added bug Something isn't working documentation Improvements or additions to documentation labels Apr 18, 2023
@chrisglein
Copy link
Member

@chiaramooney When you update the SDK min version can you also remove the versioned versions of this page?

@chrisglein chrisglein added this to the 0.72 milestone Apr 24, 2023
@chiaramooney chiaramooney mentioned this issue May 12, 2023
Merged
chiaramooney added a commit that referenced this issue May 15, 2023
@chiaramooney
Make Win10 Compatibility Doc "Static" (#836)
76f028b 
## Description

### Why
Windows 10 Compatibility doc page should remain the same no matter which
version docs the user is looking at.

Adjust docs for cutting new version of website to ensure this page
remains "static".

Resolves #830 

###### Microsoft Reviewers: [Open in
CodeFlow](https://portal.fabricbot.ms/api/codeflow?pullrequest=https://github.com/microsoft/react-native-windows-samples/pull/836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiaramooney chiaramooney

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.72
Development

Successfully merging a pull request may close this issue.

Make Win10 Compatibility Doc "Static" chiaramooney/react-native-windows-samples
3 participants
@jonthysell @chrisglein @chiaramooney