Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut Website Documentation for RNW v0.73 #903

Merged
merged 14 commits into from
Dec 8, 2023

Conversation

chiaramooney
Copy link
Collaborator

@chiaramooney chiaramooney commented Dec 6, 2023

Description

Why

Update website for RNW v0.73.

Microsoft Reviewers: Open in CodeFlow

@chiaramooney chiaramooney requested review from a team as code owners December 6, 2023 19:12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here.

@@ -13,9 +13,17 @@

namespace NativeModuleSample {

REACT_STRUCT(AsyncMethodExamplesSpec_Response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these changes may be necessary to align with the docs when the sample is updated to 0.73, it shouldn't really be a part of the docs cut.

| [0.73](https://www.npmjs.com/package/react-native-windows/v/preview) | [Preview](#preview-support) | *TBD* | *TBD* | *TBD* | *TBD* |
| [0.72](https://www.npmjs.com/package/react-native-windows/v/latest) | [Active](#active-support) | 06/23/2023 | 06/23/2023 | *TBD* | *TBD* |
| [0.73](https://www.npmjs.com/package/react-native-windows/v/latest) | [Active](#active-support) | 12/11/23 | 12/11/23 | *TBD* | *TBD* |
| [0.72](https://www.npmjs.com/package/react-native-windows/v/v0.72-stable) | [Active](#active-support) | 06/23/2023 | 06/23/2023 | 01/11/23 | 03/11/23 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be the last day of the next month, also the correct year

Suggested change
| [0.72](https://www.npmjs.com/package/react-native-windows/v/v0.72-stable) | [Active](#active-support) | 06/23/2023 | 06/23/2023 | 01/11/23 | 03/11/23 |
| [0.72](https://www.npmjs.com/package/react-native-windows/v/v0.72-stable) | [Active](#active-support) | 06/23/2023 | 06/23/2023 | 01/31/24 | 03/30/24 |

@TatianaKapos
Copy link
Contributor

The PR: microsoft/react-native-windows#12371 makes Hermes the default engine in 0.73, we will want to fix the hermes.md file before cutting the documentation

@chiaramooney chiaramooney merged commit 28ba571 into microsoft:main Dec 8, 2023
33 checks passed
@chiaramooney chiaramooney deleted the cm-cut-73 branch December 8, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants