Fix compile errors with Clang 10.0.0 (#4937)

* Fix compile errors with Clang 10.0.0 Right now the code does not compile with Clang 10.0.0 These changes should make them work on MSVC and Clang Built on a local repository using BUCK with Clang * Change files
microsoft · May 19, 2020 · 08ec22c · 08ec22c
1 parent 8a65e83
commit 08ec22c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/change/react-native-windows-2020-05-18-02-05-00-chpurrer-rnw-clang-fixes.json b/change/react-native-windows-2020-05-18-02-05-00-chpurrer-rnw-clang-fixes.json
@@ -0,0 +1,8 @@
+{
+  "type": "none",
+  "comment": "Fix compile errors with Clang 10.0.0",
+  "packageName": "react-native-windows",
+  "email": "christophpurrer@gmail.com",
+  "dependentChangeType": "none",
+  "date": "2020-05-18T09:05:00.527Z"
+}
diff --git a/vnext/Microsoft.ReactNative.Cxx/JSValue.h b/vnext/Microsoft.ReactNative.Cxx/JSValue.h
@@ -818,7 +818,7 @@ inline T JSValue::To(T &&defaultValue) const noexcept {
 }
 
 template <class T>
-static JSValue JSValue::From(T const &value) noexcept {
+JSValue JSValue::From(T const &value) noexcept {
   auto writer = MakeJSValueTreeWriter();
   WriteValue(writer, value);
   return TakeJSValue(writer);

diff --git a/vnext/ReactUWP/Utils/ValueUtils.cpp b/vnext/ReactUWP/Utils/ValueUtils.cpp
@@ -198,7 +198,7 @@ REACTWINDOWS_API_(bool) IsValidColorValue(const folly::dynamic &d) {
 
 REACTWINDOWS_API_(winrt::TimeSpan) TimeSpanFromMs(double ms) {
   std::chrono::milliseconds dur((int64_t)ms);
-  return winrt::TimeSpan(dur);
+  return winrt::TimeSpan::duration(dur);
 }
 
 } // namespace uwp