Skip to content

Commit

Permalink
[0.72] Revert back to node 16 for all images (#12709)
Browse files Browse the repository at this point in the history
## Description

The previous change #12693 tried to switch RNW 0.72 to Node 18, which broke 0.72 publish, and but was only partially fixed with #12698.

This PR completes the revert.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
RN and RNW 0.72 require node 16, building against node 18 has issues, and even if we could fix those, that would be a breaking change to a stable branch.

### What
N/A

## Screenshots
N/A

## Testing
N/A

## Changelog
Should this change be included in the release notes: no
  • Loading branch information
jonthysell committed Feb 10, 2024
1 parent ff0ebad commit 4db77b3
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .ado/compliance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ parameters:
default:
Medium:
name: rnw-pool-4-microsoft
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
Large:
name: rnw-pool-8-microsoft
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
- name: forceCodeQL
displayName: Force CodeQL to rebuild databases
type: boolean
Expand Down
6 changes: 3 additions & 3 deletions .ado/continuous.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ parameters:
default:
Small:
name: rnw-pool-2
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
Medium:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
MediumNode16:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022
Large:
name: rnw-pool-8
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022

stages:
- template: stages.yml
Expand Down
3 changes: 3 additions & 0 deletions .ado/templates/react-native-init.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ steps:
- script: yarn config set registry http://localhost:4873
displayName: Modify yarn config to point to local verdaccio server

- script: yarn config set ignore-engines true
displayName: Disable node engine checks # workaround for issue #12711

- ${{ if eq(parameters.useNuget, true) }}:
- script: |
npx --yes react-native-windows-init@latest --verbose --version $(npmVersion) --overwrite --language ${{ parameters.language }} --projectType ${{ parameters.projectType }} ${{ parameters.additionalInitArguments }} --experimentalNuGetDependency true --nuGetTestFeed $(System.DefaultWorkingDirectory)\NuGetTestFeed
Expand Down
6 changes: 3 additions & 3 deletions .ado/windows-vs-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ parameters:
default:
Small:
name: rnw-pool-2
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
Medium:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
MediumNode16:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022
Large:
name: rnw-pool-8
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022

stages:
- template: stages.yml
Expand Down

0 comments on commit 4db77b3

Please sign in to comment.