Skip to content

Commit

Permalink
VS 2019 Fixes (#2396)
Browse files Browse the repository at this point in the history
* Fix unit test build (something upgraded with 2019 also broken 2017 builds) - SkipUnionWinmd prevents .net files from attempting to be bundled into the appx

* Enable newer compiler when using VS2019
  • Loading branch information
ahimberg committed May 29, 2019
1 parent f12fd7e commit 6c5ede4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions vnext/PropertySheets/React.Cpp.props
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

<PropertyGroup Label="Configuration">
<PlatformToolset>v141</PlatformToolset>
<PlatformToolset Condition="'$(VisualStudioVersion)' == '16.0'">v142</PlatformToolset>
<GenerateProjectSpecificOutputFolder>false</GenerateProjectSpecificOutputFolder>
<CharacterSet>Unicode</CharacterSet>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<UnitTestPlatformVersion>15.0</UnitTestPlatformVersion>
<ProjectSubType>NativeUnitTestProject</ProjectSubType>
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
<SkipUnionWinmd>true</SkipUnionWinmd>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<Import Project="$(ReactNativeWindowsDir)PropertySheets\React.Cpp.props" />
Expand Down

0 comments on commit 6c5ede4

Please sign in to comment.