Use IsNativeControlWithSelfLayout in ReplaceView (#10394)

* Use `IsNativeControlWithSelfLayout` in ReplaceView Since we strictly speaking don't need to reset the self measure func when swapping out a native view, we can just use the `IsNativeControlWithSelfLayout` check. * Change files
microsoft · Sep 12, 2022 · 87c0e9d · 87c0e9d
1 parent c767e45
commit 87c0e9d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/change/react-native-windows-99b4d0ab-5a17-4781-8844-7bc094e0a18c.json b/change/react-native-windows-99b4d0ab-5a17-4781-8844-7bc094e0a18c.json
@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Use `IsNativeControlWithSelfLayout` in ReplaceView",
+  "packageName": "react-native-windows",
+  "email": "erozell@outlook.com",
+  "dependentChangeType": "patch"
+}
diff --git a/vnext/Microsoft.ReactNative/Modules/NativeUIManager.cpp b/vnext/Microsoft.ReactNative/Modules/NativeUIManager.cpp
@@ -850,8 +850,7 @@ void NativeUIManager::ReplaceView(ShadowNode &shadowNode) {
     if (it != m_tagsToYogaNodes.end()) {
       YGNodeRef yogaNode = it->second.get();
 
-      YGMeasureFunc func = pViewManager->GetYogaCustomMeasureFunc();
-      if (func != nullptr) {
+      if (pViewManager->IsNativeControlWithSelfLayout()) {
         auto context = std::make_unique<YogaContext>(node.GetView());
         YGNodeSetContext(yogaNode, reinterpret_cast<void *>(context.get()));