Skip to content

Commit

Permalink
[0.71] Fix BinSkim warnings for Desktop (#12041)
Browse files Browse the repository at this point in the history
This PR backports #11816 to 0.71.

BinSkim has been throwing warnings for Desktop ever since the upgrade to BinSkim@4. Particularly this is from scanning the Hermes and V8 dlls.

However both are sourced from their own Microsoft-owned repos and only consumed here via published NuGets. BinSkim should be running on those repos (if required) not here in RNW.

This PR updates the pipeline to only test the binaries built by this pipeline.
  • Loading branch information
jonthysell committed Aug 18, 2023
1 parent f8ab997 commit b7b0ea9
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions .ado/jobs/desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,7 @@ jobs:
InputType: 'Basic'
Function: 'analyze'
TargetPattern: 'guardianGlob'
# Scanning v8jsi.dll in x64/x86 only, because PDBs are stripped in ARM64
${{ if ne(matrix.BuildPlatform, 'ARM64') }}:
AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\\React.Windows.Desktop.DLL\*.dll'
${{ else }}:
AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\\React.Windows.Desktop.DLL\react-native-win32.dll'
AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\React.Windows.Desktop.DLL\react-native-win32.dll'
AnalyzeVerbose: true
toolVersion: 'Latest'
continueOnError: true
Expand Down

0 comments on commit b7b0ea9

Please sign in to comment.