Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric: Change in a JS view's accessibilityValue prop does not fire the appropriate UIA update event #12361

Open
jonthysell opened this issue Nov 7, 2023 · 0 comments
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up)
Milestone

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Nov 7, 2023

Problem Description

In PR #12287, support for the accessbilityValue prop was added. However it seems like only the TextInput actually files an event (when the text changes). However other custom views which set (and change) that property won't fire an event to notify UIA.

I.e. ComponentBaseComponentView should have something like this in updateAccessibilityProps:

winrt::Microsoft::ReactNative::implementation::UpdateUiaProperty(
      m_uiaProvider, UIA_ValueValuePropertyId, oldViewProps.accessibilityValue.text, newViewProps.accessibilityValue.text);

Steps To Reproduce

Code analysis

Expected Results

No response

CLI version

npx react-native -v

Environment

npx react-native info

Target Platform Version

None

Target Device(s)

No response

Visual Studio Version

None

Build Configuration

None

Snack, code example, screenshot, or link to a repository

No response

@jonthysell jonthysell added bug Area: Fabric Support Facebook Fabric labels Nov 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 7, 2023
@chrisglein chrisglein added Area: Accessibility PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Nov 9, 2023
@chrisglein chrisglein added this to the Next milestone Nov 9, 2023
@chrisglein chrisglein assigned Yajur-Grover and unassigned YajurG Jan 31, 2024
@Yajur-Grover Yajur-Grover modified the milestones: Next, Backlog Feb 23, 2024
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
@Yajur-Grover Yajur-Grover removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up)
Projects
Status: No status
Development

No branches or pull requests

4 participants