Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Expand native theming implementation #12287

Merged
merged 13 commits into from
Oct 25, 2023

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Oct 23, 2023

Description

  • Changed usage of platform colors/brushes to use a context aware Theme object allowing future tree specific theming and native theme injection.
  • Added values to the platform colors for usage by Switch, TextInput and ActivityIndicator.
  • Added a brush cache.
  • Optimize rootComponentView lookup.
  • Updated switch visuals to handle more visual states and use theme colors rather than hard coded values.
  • Standardized more component border handling
  • Modified CompActivityVisual, CompCaretVisual, and CompSwitchThumbVisual to take brushes instead of colors for expanded brush support
  • Implemented ScrollItem and Value accessibility patterns
  • Implemented IsOffScreen accessibility property
  • Stopped creating automation peers internally until they are requested by a UIA client
  • Fixed an issue where incorrect bounding rect would be returns by components within in a ScrollView that was scrolled to a non-zero offset
  • Updated E2E test logic to use SetValue to clear the search textinput rather than entering backspaces
  • Added retry logic to E2E test page navigation to improve reliability of E2E tests
  • Fixed a crash when reloading the instance in the fabric playground app
  • Fixed a crash when using mousewheel in non-islands fabric apps
  • Fixed intermittent crash getting automation peer from a loading rootview
  • Fixed issue in hittesting where items outside of the viewport of a ScrollView would still be hit tested.
Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested review from a team as code owners October 23, 2023 21:19
@acoates-ms acoates-ms changed the title Expand native theming implementation [Fabric] Expand native theming implementation Oct 25, 2023
@acoates-ms acoates-ms added the Area: Fabric Support Facebook Fabric label Oct 25, 2023
@acoates-ms acoates-ms mentioned this pull request Oct 25, 2023
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing changes look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Fabric Support Facebook Fabric New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants