-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failed with message Error: MSBuild tools not found. Check your build configuration. #2420
Comments
Can you provide details of your setup? Which VS version, Windows SDK, setup steps are you running? |
I also got this issue, I'm on Win 10 Insider Preview 18890, VS 2019 (as per requirements VS2017 or greater). Followed Getting-started-current and failed on that step (run on VS/run-windows). Installed C++ workload and MSVC/ATL 141 build tools. Still fails. |
I had the same issue until I installed VS 2017 specifically. |
I was able to solve using v-next |
Anyone knows how to run it on vs 2019? |
Pretty sure it's going to be related to a lack of support here:
I can get it to finish building and start by (and please don't do this and expect anything but a hack, but...) doing the following in the checkMSBuildVersion() function, just before the final return:
In order to get that to be called, I updated the array of possible version values at line 12 of the file to:
Finally, you need to hack the buildProject() function as well to handle VS2019 version numbers... look for the comment around line 40 referring to VS2017 and do something similar for V16/VS2019.
Also UPDATE: there's a tracking issue for VS2019 support here: #2320 . |
@stratospheres Tank you very much! It's works! |
The same here, MS should fix this ASAP |
Build failed with message Error: MSBuild tools not found. Check your build configuration. facing with the same issue can any one help to solve this, Thanks in advance |
I tried with both the VS 2017 as well as 2019 and even tried doing above hack. But not succeed. Getting same error. |
So frustrating that this doesn't work with MS' own latest dev tools and doesn't work with the latest version of react native. I wish MS would devote more resources to this project. |
Apologies on this. As @stratospheres pointed out, we are working on making the CLI for vnext work with VS 2019. Issue #2320 is tracking this (we just submitted a first PR #2539) . You can follow the Advanced install method specified here - Advanced install for working on vNext with VS 2019 until we fix the buildpath issues with the CLI. |
@harinikmsft Thanks for addressing issue and giving workaround. |
@harinikmsft, still facing the same issue with rnwindows 0.57 versions. |
Sorry to hear that @hmheng. @marlenecota - can you take a look again? |
@harinikmsft Even same behavior for me. :( It's not working. |
Same here on version 0.57.1, haven't tried vnext since due to lack of transform animation. |
Ah, my fix was only for vnext. @ShrinathGupta were you also using current? |
If we upgrade to vnext, it works fine on Windows, but it will break android compilation. I haven't try ios yet. |
@marlenecota Yes i was using vnext and i was building uwp app. |
@hmheng, @ShrinathGupta - 0.57.2 and 0.58.0-rc.2 have been patched. Please give that a go. |
@marlenecota thank you.. PS D:\PS\Repos\RNWindows> react-native windows --template current However, if I use react-native windows --windowsVersion ~0.57.. it works with RNW0.57.2 For RN 0.58.. |
@marlenecota It has been long time since i worked on it. Good news today i checked and it worked. Awesome thanks @marlenecota 👏 💯 |
If anybody wants to give a try to react native windows vnext. |
Sounds like this is resolved. |
just provided "msbuild.exe" path to "toolsPath" var ,in "\node_modules\react-native-windows\local-cli\runWindows\utils\msbuildtools.js"and now it is working ,thank you. |
Can you explain this in more detail, please? |
I can not find any path like this |
@gaurav8809 This issue is almost a year old. Can you open a fresh issue that contains your environment info? |
I can provide you my environment info here
|
Please open a new issue and follow the instructions in the template. That's the best way to help us to provide support. |
The text was updated successfully, but these errors were encountered: