Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document View - Style API completion #2796

Closed
17 of 25 tasks
harinikmsft opened this issue Jul 18, 2019 · 7 comments
Closed
17 of 25 tasks

Document View - Style API completion #2796

harinikmsft opened this issue Jul 18, 2019 · 7 comments
Labels
Area: Borders and Brushes Documentation enhancement Epic Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
Core Feature Parity
Milestone
Backlog

Comments

@harinikmsft
Copy link
Contributor

harinikmsft commented Jul 18, 2019 •
edited by kmelmon
Loading

This is a placeholder issue to validate and implement (if not already supported) the remaining Style props on View:

Not implementing

  • elevation
    (Android-only) Sets the elevation of a view, using Android's underlying elevation API. This adds a drop shadow to the item and affects z-order for overlapping views. Only supported on Android 5.0+, has no effect on earlier versions.
@harinikmsft harinikmsft added this to the vNext Milestone 3 milestone Jul 18, 2019
@harinikmsft harinikmsft added this to To do in Core Feature Parity via automation Jul 18, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 18, 2019
@harinikmsft harinikmsft added Epic and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jul 24, 2019
@harinikmsft harinikmsft moved this from To do to In progress in Core Feature Parity Aug 2, 2019
@harinikmsft harinikmsft moved this from In progress to Done in Core Feature Parity Aug 29, 2019
@chrisglein
Copy link
Member

Expanded list of border* props so we can be specific. Will be breaking out into a few issues soon.
Also elevation was missing from the list. Not sure if that was intentional (@harinikmsft ?).

@chrisglein chrisglein mentioned this issue Sep 4, 2019
Closed
8 tasks
@harinikmsft
Copy link
Contributor Author

I had left out elevation since it was Android-only which meant it may not be part of lean-core long term.

@chrisglein chrisglein mentioned this issue Sep 4, 2019
Closed
6 tasks
@chrisglein
Copy link
Member

I've split out the individual issues and put them on this project board: #2796
At which point we don't need this issue. But we will want the information on an API. @harinikmsft can you coordinate that? (sync with Savoy/Kiki) Converting this issue to a documentation issue.

@chrisglein chrisglein changed the title [Component]: View - Style props completion Document View - Style API completion Oct 29, 2019
@chrisglein chrisglein mentioned this issue Nov 4, 2019
Closed
@harinikmsft harinikmsft removed their assignment Jan 28, 2020
@harinikmsft
Copy link
Contributor Author

@kikisaints - can you take a look at documenting this?

@kikisaints
Copy link
Contributor

@harinikmsft can you defined documenting - do you mean put this up in the API section of our RNW website?

@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 10, 2020
@chrisglein
Copy link
Member

Switching Facebook label to specific issue on mixed borders: #3077

@chrisglein chrisglein added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 30, 2023
@chrisglein
Copy link
Member

Not planned for Paper renderer.
For the Fabric renderer, tracked here: #11135

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Borders and Brushes Documentation enhancement Epic Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
No open projects
Core Feature Parity
  
Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@kikisaints @harinikmsft @chrisglein