Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <react-native-screens> #4152

Closed
1 task
robertev opened this issue Feb 20, 2020 · 6 comments
Closed
1 task

Support <react-native-screens> #4152

robertev opened this issue Feb 20, 2020 · 6 comments
Assignees
Labels
enhancement Extensions Tracks issues against community modules and extensions Partner: AppConsult AppConsult managed customers Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone

Comments

@robertev
Copy link

robertev commented Feb 20, 2020

Support react-native-screens on RNW vNext

Basic Info

Overview of Required Functionality

kmagiera
Native navigation primitives for React Native app.
PureJS - no

Again, a dependency of React Native Navigation

@robertev robertev added Extensions Tracks issues against community modules and extensions vnext labels Feb 20, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 20, 2020
@stmoy stmoy added this to Backlog in Community Module Requests via automation Feb 20, 2020
@harinikmsft harinikmsft added this to the MVP+ (vNext M5) milestone Feb 20, 2020
@harinikmsft harinikmsft added the Partner: AppConsult AppConsult managed customers label Feb 20, 2020
@harinikmsft harinikmsft modified the milestones: MVP+ (vNext M5), Backlog Feb 20, 2020
@harinikmsft harinikmsft removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 20, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@stmoy stmoy removed their assignment Sep 10, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Sep 23, 2020
@creambyemute
Copy link

Temporary solution would be to just not enableScreens() on Windows. I made a App.windows.tsx removing the rn-gh import and the react-native-screens import/enabling.

@stmoy stmoy self-assigned this Dec 17, 2020
@stmoy stmoy added the Assigned to External Work being handled by a non-core contributor (assignee is coordinating that work) label Dec 17, 2020
@stmoy stmoy moved this from Backlog to In progress in Community Module Requests Dec 17, 2020
@stmoy stmoy removed the Assigned to External Work being handled by a non-core contributor (assignee is coordinating that work) label Apr 20, 2021
@stmoy stmoy moved this from In progress to Backlog in Community Module Requests Apr 20, 2021
WoLewicki pushed a commit to software-mansion/react-native-screens that referenced this issue Jul 12, 2021
Adds initial support for react-native-windows.

The more advanced customization options for animations/transitions were not implemented as part of this initial pass.

They will be implemented later as needed.

Also this implementation is being done on behalf of Microsoft.

For context: microsoft/react-native-windows#4152
@chiaramooney
Copy link
Contributor

Partial implementation now merged into react-native-screens repo. Still some work to be done here including missing animations when doing screen transitioning, and native navigation stack support. There was also a bug reported on the PR: "It looks like you're unable to navigate back to a previously rendered screen. For example, calling navigator.navigate("Home") after navigating to Notifications renders a completely blank screen, as does calling navigator.goBack()." that should be investigated.

@chiaramooney chiaramooney added the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Jul 19, 2021
@chrisglein
Copy link
Member

We have some part of screens, so that's good. We have two scenarios to check in on before closing this issue:

  • @robertev needs above are met (with native navigation)
  • react-navigation no longer experiences perf issues with pages on the backstack not being discarded

@stmoy FYI

@chrisglein chrisglein removed the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Jul 19, 2021
@stmoy stmoy moved this from Backlog to In progress in Community Module Requests Jul 19, 2021
@chiaramooney
Copy link
Contributor

Most recent npm publish on react-native-screens contains Windows support. Just tried to add the module to react-native-gallery and the module fails to build successfully. Need to add an additional work item to this task of fixing up the implementation that was already merged.

@chiaramooney
Copy link
Contributor

Module now builds successfully on Windows. Make note to add to the list of functionality that still needs to be added to the module: Support for detaching inactive screens.

robertomartinez09515 added a commit to robertomartinez09515/native-mansion-screen-react that referenced this issue Jul 25, 2022
Adds initial support for react-native-windows.

The more advanced customization options for animations/transitions were not implemented as part of this initial pass.

They will be implemented later as needed.

Also this implementation is being done on behalf of Microsoft.

For context: microsoft/react-native-windows#4152
@chrisglein chrisglein added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 16, 2023
@chrisglein
Copy link
Member

Partial implementation exists. Closing this module request. Not that this module shouldn't receive a more complete Windows implementation, but it makes more sense to track gaps on the module's repo rather this repo.

Community Module Requests automation moved this from In progress to Complete Sep 7, 2023
mccoyplayer pushed a commit to mccoyplayer/reactScreen that referenced this issue Feb 9, 2024
Adds initial support for react-native-windows.

The more advanced customization options for animations/transitions were not implemented as part of this initial pass.

They will be implemented later as needed.

Also this implementation is being done on behalf of Microsoft.

For context: microsoft/react-native-windows#4152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extensions Tracks issues against community modules and extensions Partner: AppConsult AppConsult managed customers Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
Development

No branches or pull requests

6 participants