New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish remaining TODOs for UIImplementation #70

Closed

rozele opened this issue Dec 30, 2015 · 1 comment

Assignees

Milestone

Core Framework - V1

Collaborator

rozele commented Dec 30, 2015

There are various remaining tasks for the UIImplementation, most notably around dealing with measurement and resizing.

The classes that need to be addressed are:

UIImplementation
RootViewManager
OnLayoutEvent
NativeViewHierarchyOptimizer
NativeViewHierarchyManager

rozele added this to the Core Framework - V1 milestone

rozele added the in progress label

rozele self-assigned this

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

1361c0d

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

d4e116c

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Merge pull request #76 from CatalystCode/issue70

bb9a76c

Towards #70 - Adds implementation for NativeViewHierarchyManager

rozele added a commit that referenced this issue


          Towards #70 - Implements the NativeViewHierarchyOptimizer

5cb6d5e

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation of ReactShadowNode

02def6e

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

rozele added a commit that referenced this issue


          Merge pull request #77 from CatalystCode/issue70

38c0476

Towards #70.

rozele mentioned this issue

Implement UIManagerModule #53

Closed

Collaborator Author

rozele commented Jan 4, 2016

NativeViewHierarchyManager, NativeViewHierarchyOptimizer and UIImplementation mostly done, except for things related to layout measurement and animation.

rozele added a commit that referenced this issue


          Towards #70 - Finishes up some of the UIImplementation and wires up O…

b7b02ea

…nBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

rozele added a commit that referenced this issue


          Merge pull request #87 from CatalystCode/issue70

ad8d3ba

Towards #70 - Finishes up some of the UIImplementation and wires up OnBatchComplete

rozele closed this as completed

rozele removed the in progress label

rozele reopened this

rozele added the in progress label

rozele closed this as completed

rozele removed the in progress label

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

954b8e1

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Towards #70 - Implements the NativeViewHierarchyOptimizer

f3949d7

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation of ReactShadowNode

cf85a6c

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

rozele added a commit that referenced this issue


          Towards #70 - Finishes up some of the UIImplementation and wires up O…

58368ee

…nBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

09f375a

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Towards #70 - Implements the NativeViewHierarchyOptimizer

8a48d9f

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation of ReactShadowNode

835b7a5

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

rozele added a commit that referenced this issue


          Towards #70 - Finishes up some of the UIImplementation and wires up O…

712c98a

…nBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

9d8786d

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Towards #70 - Implements the NativeViewHierarchyOptimizer

4e21b43

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation of ReactShadowNode

8e091fd

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

rozele added a commit that referenced this issue


          Towards #70 - Finishes up some of the UIImplementation and wires up O…

e9a7bdd

…nBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

ae7c5a5

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Towards #70 - Implements the NativeViewHierarchyOptimizer

e98fecd

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation of ReactShadowNode

ded6de7

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

rozele added a commit that referenced this issue


          Towards #70 - Finishes up some of the UIImplementation and wires up O…

a0cdf7f

…nBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation for NativeViewHierarchyManager

7df8481

Remaining TODOs surrounding layout, popup menu, measurement, etc.

rozele added a commit that referenced this issue


          Towards #70 - Implements the NativeViewHierarchyOptimizer

ccf3edc

rozele added a commit that referenced this issue


          Towards #70 - Adds implementation of ReactShadowNode

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

rozele added a commit that referenced this issue


          Towards #70 - Finishes up some of the UIImplementation and wires up O…

3f0eb8f

…nBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

GantMan pushed a commit to infinitered/react-native-windows that referenced this issue


          Towards microsoft#70 - Adds implementation for NativeViewHierarchyMan…

b466047

…ager

Remaining TODOs surrounding layout, popup menu, measurement, etc.

GantMan pushed a commit to infinitered/react-native-windows that referenced this issue


          Towards microsoft#70 - Implements the NativeViewHierarchyOptimizer

10d34e6

GantMan pushed a commit to infinitered/react-native-windows that referenced this issue


          Towards microsoft#70 - Adds implementation of ReactShadowNode

9106e0c

The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.

GantMan pushed a commit to infinitered/react-native-windows that referenced this issue


          Towards microsoft#70 - Finishes up some of the UIImplementation and w…

a082078

…ires up OnBatchComplete

The UI operations are queued up until all calls from the native modules thread have finished executing (so they can potentially be optimized into fewer calls). This changeset wires up the OnBatchComplete event from the ReactBridge and also implements a few of the remaining UIImplementation TODOs.

There are still TODOs surrounding measurement, layout and animation.

rozele pushed a commit that referenced this issue


          Merge pull request #70 from tadeuzagallo/remove-dead-code

3203e86

Remove unused code pointed by Xcode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment