[Fabric] Add switch's 'trackColor' #11234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaKapos
changed the title
TatianaKapos
changed the title
marlenecota
reviewed
Mar 3, 2023
vnext/Microsoft.ReactNative/Fabric/Composition/SwitchComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/SwitchComponentView.cpp
Outdated
Show resolved
Hide resolved
marlenecota
reviewed
Mar 20, 2023
| // switch track - outline | ||
| D2D1_ROUNDED_RECT track = D2D1::RoundedRect(trackRect, trackCornerRadius, trackCornerRadius); | ||
| if ((!switchProps->onTintColor && switchProps->value) || (!switchProps->tintColor && !switchProps->value)) { | ||
| d2dDeviceContext->DrawRoundedRectangle(track, defaultBrush.get()); |
There was a problem hiding this comment.
Could simplify by make this the 'else' case below.
marlenecota
approved these changes
Mar 20, 2023
157 tasks
jonthysell
approved these changes
Mar 23, 2023
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 'track color' to Switch in Fabric
Type of Change
Why
Resolves #11212
Screenshots
Testing
Tested locally
Microsoft Reviewers: Open in CodeFlow