Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SBOM signing on CI/PRs #11657

Merged
merged 2 commits into from
May 25, 2023
Merged

Disable SBOM signing on CI/PRs #11657

merged 2 commits into from
May 25, 2023

Conversation

jonthysell
Copy link
Contributor

@jonthysell jonthysell commented May 25, 2023

Description

Our SBOM manifests can only be signed when running pipelines in the internal ADO for publishing official builds. This PR changes the config not not sign the manifests for PR/CI.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

Unblock PRs.

What

Added variable to only enable signing when on the right ADO instance.

Screenshots

N/A

Testing

N/A

Microsoft Reviewers: Open in CodeFlow

@jonthysell jonthysell marked this pull request as ready for review May 25, 2023 19:13
@jonthysell jonthysell requested review from a team as code owners May 25, 2023 19:13
@jonthysell jonthysell merged commit 4837761 into main May 25, 2023
44 checks passed
@jonthysell jonthysell deleted the jonthysell-patch-1 branch May 25, 2023 19:17
jonthysell added a commit that referenced this pull request May 25, 2023
Backports #11657 to 0.72.

## Description

Our SBOM manifests can only be signed when running pipelines in the internal ADO for publishing official builds. This PR changes the config not not sign the manifests for PR/CI.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
Unblock PRs.

### What
Added variable to only enable signing when on the right ADO instance.

## Screenshots
N/A

## Testing
N/A
 main
jonthysell added a commit that referenced this pull request May 25, 2023
Backports #11657 to 0.71.

## Description

Our SBOM manifests can only be signed when running pipelines in the internal ADO for publishing official builds. This PR changes the config not not sign the manifests for PR/CI.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
Unblock PRs.

### What
Added variable to only enable signing when on the right ADO instance.

## Screenshots
N/A

## Testing
N/A
jonthysell added a commit that referenced this pull request May 25, 2023
Backports #11657 to 0.70.

## Description

Our SBOM manifests can only be signed when running pipelines in the internal ADO for publishing official builds. This PR changes the config not not sign the manifests for PR/CI.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
Unblock PRs.

### What
Added variable to only enable signing when on the right ADO instance.

## Screenshots
N/A

## Testing
N/A
jonthysell added a commit that referenced this pull request May 25, 2023
Backports #11657 to 0.69.

## Description

Our SBOM manifests can only be signed when running pipelines in the internal ADO for publishing official builds. This PR changes the config not not sign the manifests for PR/CI.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
Unblock PRs.

### What
Added variable to only enable signing when on the right ADO instance.

## Screenshots
N/A

## Testing
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant