Attempt AddNetworkingHandler if HTTP module was not ready #11926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GH/11439/blobhand
jonthysell
reviewed
Jul 24, 2023
jonthysell
approved these changes
Jul 24, 2023
tudorms
approved these changes
Jul 24, 2023
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 24, 2023
…11926) * Update packages.lock * Remove HttpModule.h from OInstance.cpp * Remove runtime option Blob.EnableModule * Call SetupHttpResource only once * Attempt AddNetworkingHandler if HTTP module was not ready * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 24, 2023
…11926) * Update packages.lock * Remove HttpModule.h from OInstance.cpp * Remove runtime option Blob.EnableModule * Call SetupHttpResource only once * Attempt AddNetworkingHandler if HTTP module was not ready * Change files
This was referenced Jul 24, 2023
JunielKatarn
added a commit
that referenced
this pull request
Jul 24, 2023
) (#11931) * Attempt AddNetworkingHandler if HTTP module was not ready (#11926) * Update packages.lock * Remove HttpModule.h from OInstance.cpp * Remove runtime option Blob.EnableModule * Call SetupHttpResource only once * Attempt AddNetworkingHandler if HTTP module was not ready * Change files * Remove change files * Change files
JunielKatarn
added a commit
that referenced
this pull request
Jul 24, 2023
) (#11932) * Attempt AddNetworkingHandler if HTTP module was not ready (#11926) * Update packages.lock * Remove HttpModule.h from OInstance.cpp * Remove runtime option Blob.EnableModule * Call SetupHttpResource only once * Attempt AddNetworkingHandler if HTTP module was not ready * Change files * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Aug 29, 2023
…11926) * Update packages.lock * Remove HttpModule.h from OInstance.cpp * Remove runtime option Blob.EnableModule * Call SetupHttpResource only once * Attempt AddNetworkingHandler if HTTP module was not ready * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Aug 29, 2023
…11926) * Update packages.lock * Remove HttpModule.h from OInstance.cpp * Remove runtime option Blob.EnableModule * Call SetupHttpResource only once * Attempt AddNetworkingHandler if HTTP module was not ready * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Under certain conditions (i.e. setting
UseWebDebuggertofalse, Blob methodaddNetworkingHandlerwould be call prematurely.Resolves #11439
What
If the Blob module HTTP resource dependency is not initialized when
addNetworkingHandleris called, expose the underlying Blob resource using the property bag and re-invoke that Blob method once the HTTP resource is ready.Testing
Applied changes to sample MSRN apps (i.e.
react-native-gallery).Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/react-native-windows/pull/11926&drop=dogfoodAlpha