Allow disabling Blob Cxx module #11979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issues/11439/blobhand-desktop
dannyvv
approved these changes
Aug 4, 2023
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Aug 4, 2023
* Define FetchTest * Implement fetch test * Allow disabling Blob Cxx module * Change files * Format FetchTest.js * yarn lint
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Aug 4, 2023
* Define FetchTest * Implement fetch test * Allow disabling Blob Cxx module * Change files * Format FetchTest.js * yarn lint
This was referenced Aug 4, 2023
JunielKatarn
added a commit
that referenced
this pull request
Aug 4, 2023
* Allow disabling Blob Cxx module (#11979) * Define FetchTest * Implement fetch test * Allow disabling Blob Cxx module * Change files * Format FetchTest.js * yarn lint * Remove change files * Change files
JunielKatarn
added a commit
that referenced
this pull request
Aug 4, 2023
* Allow disabling Blob Cxx module (#11979) * Define FetchTest * Implement fetch test * Allow disabling Blob Cxx module * Change files * Format FetchTest.js * yarn lint * Remove change files * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Aug 29, 2023
* Define FetchTest * Implement fetch test * Allow disabling Blob Cxx module * Change files * Format FetchTest.js * yarn lint
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Aug 29, 2023
* Define FetchTest * Implement fetch test * Allow disabling Blob Cxx module * Change files * Format FetchTest.js * yarn lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows disabling the Blob module in Desktop apps.
Type of Change
Why
Host apps that override the RNW-provided HTTP module will encounter issues if they don't provide Blob support, due to the inter-dependency between both modules.
What
Introduces runtime option
Blob.DisableModule.Testing
Added
RNTesterIntegrationTests::Fetch.Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/react-native-windows/pull/11979&drop=dogfoodAlpha