[0.74] [Fabric] Support blob: images #13296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acks (microsoft#13285) * [Fabric] Support blob: images, and provide better image.onError callbacks * Change files * Remove some test code * Add user-agent * Add public API to set default User-Agent header * various fixes * fix snapshots * Rename Networking -> HttpSettings * Change files * fix * Http.UserAgent RuntimeOption needs to be set before the HttpResource is created
TatianaKapos
approved these changes
Jun 4, 2024
marlenecota
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #13285 to 0.74
Some slight modifications to the original PR to deal with the fact that in 0.74 the fabric code didn't include the ImageErrorInfo struct, or report those errors to JS.
I basically replaced the uses of ImageErrorInfo with a std::string. -- It is not passed to JS in 0.74.
Microsoft Reviewers: Open in CodeFlow