Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v8runtime export to the def file #2472

Merged
1 commit merged into from
May 15, 2019
Merged

Add v8runtime export to the def file #2472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions vnext/Desktop.DLL/react-native-win32.x64.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ EXPORTS
??1Value@jsi@facebook@@QEAA@XZ
??1Buffer@jsi@facebook@@UEAA@XZ
?makeChakraJsiRuntime@chakraruntime@jsi@facebook@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QEAUChakraJsiRuntimeArgs@123@@Z
?makeV8Runtime@v8runtime@facebook@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@XZ


YGNodeNew
Expand Down
1 change: 1 addition & 0 deletions vnext/Desktop.DLL/react-native-win32.x86.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ EXPORTS
??1Value@jsi@facebook@@QAE@XZ
??1Buffer@jsi@facebook@@UAE@XZ
?makeChakraJsiRuntime@chakraruntime@jsi@facebook@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QAUChakraJsiRuntimeArgs@123@@Z
?makeV8Runtime@v8runtime@facebook@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@XZ


YGLog
Expand Down
1 change: 1 addition & 0 deletions vnext/ReactCommon/ReactCommon.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Platform.cpp" Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Runtime_shared.cpp" Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Runtime_win.cpp" Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
<ClCompile Include="nov8.cpp" Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' != 'true'"/>
<ClCompile Include="$(YogaDir)\yoga\Utils.cpp" />
<ClCompile Include="$(YogaDir)\yoga\YGConfig.cpp" />
<ClCompile Include="$(YogaDir)\yoga\YGEnums.cpp" />
Expand Down
14 changes: 14 additions & 0 deletions vnext/ReactCommon/nov8.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#include <memory>
#include <jsi/jsi.h>

namespace facebook {
namespace v8runtime {

// This exists just to satisfy the export requirements, so that we can share the same .def file between GitHub and the Office internal build system
std::unique_ptr<jsi::Runtime> makeV8Runtime()
{
std::abort();
}

} // namespace v8runtime
} // namespace facebook