clang-format: add rule for pch.h and generated files #2767

marlenecota · 2019-07-13T05:27:49Z

This makes it so pch.h is always at the top and cppwinrt generated files get moved to below the "main" header.

File: Foo.cpp

#include pch.h
#include Foo.h
#include Foo.g.cpp

Microsoft Reviewers: Open in CodeFlow

ghost · 2019-07-13T05:30:05Z

Hello @marlenecota!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 57 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

clang-format: add rule for pch.h and generated files

c72ca60

marlenecota requested a review from acoates-ms July 13, 2019 05:27

marlenecota requested a review from a team as a code owner July 13, 2019 05:27

marlenecota added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jul 13, 2019

chrisglein approved these changes Jul 15, 2019

View reviewed changes

akrantz approved these changes Jul 15, 2019

View reviewed changes

ghost merged commit ba92a18 into microsoft:master Jul 15, 2019

marlenecota deleted the clang-includes branch September 8, 2020 21:54

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clang-format: add rule for pch.h and generated files #2767

clang-format: add rule for pch.h and generated files #2767

marlenecota commented Jul 13, 2019 •

edited by ghost

ghost commented Jul 13, 2019

clang-format: add rule for pch.h and generated files #2767

clang-format: add rule for pch.h and generated files #2767

Conversation

marlenecota commented Jul 13, 2019 • edited by ghost

Microsoft Reviewers: Open in CodeFlow

ghost commented Jul 13, 2019

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

marlenecota commented Jul 13, 2019 •

edited by ghost

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.