Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request to fix unreferenced formal parameter in ToExponential (double-conversion.h) - Issue #3014 #3466

Closed
wants to merge 13 commits into from
Closed

request to fix unreferenced formal parameter in ToExponential (double-conversion.h) - Issue #3014 #3466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a18292a
code clean up -unreferenced formal parameter
agarcia-caicedo Oct 18, 2019
20e6261
Change files
agarcia-caicedo Oct 18, 2019
158df08
windows target platform version
agarcia-caicedo Oct 19, 2019
a503bd4
windows target platform
agarcia-caicedo Oct 19, 2019
bf37936
Revert "applying package updates ***NO_CI***"
agarcia-caicedo Oct 20, 2019
1ab3126
Revert "Change files"
agarcia-caicedo Oct 20, 2019
e10c6c1
Revert "windows target platform version"
agarcia-caicedo Oct 20, 2019
3153d0c
Revert "windows target platform"
agarcia-caicedo Oct 20, 2019
697607c
updating the right versions of the packages
agarcia-caicedo Oct 20, 2019
01ac3ee
right version of packages
agarcia-caicedo Oct 20, 2019
0992735
Merge pull request #1 from microsoft/master
agarcia-caicedo Oct 20, 2019
bfbc017
Merge pull request #3 from microsoft/master
agarcia-caicedo Oct 28, 2019
e190c5d
Merge branch 'master' into issue-3014
agarcia-caicedo Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/react-native-windows-2019-10-17-22-02-26-auto-update-versions060.0microsoft.8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"comment": "Updating react-native to version: 0.60.0-microsoft.8",
"packageName": "react-native-windows",
"email": "53619745+rnbot@users.noreply.github.com",
"commit": "35f748784744598ebea97c6b039a14a008547f50",
"date": "2019-10-17T22:02:26.475Z",
"file": "D:\\a\\1\\s\\change\\react-native-windows-2019-10-17-22-02-26-auto-update-versions060.0microsoft.8.json"
}
9 changes: 9 additions & 0 deletions ...act-native-windows-extended-2019-10-17-22-02-28-auto-update-versions060.0microsoft.8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"comment": "Updating react-native to version: 0.60.0-microsoft.8",
"packageName": "react-native-windows-extended",
"email": "53619745+rnbot@users.noreply.github.com",
"commit": "2b9de0838622a57253f7cef8d4b15fdbd9bf3e1f",
"date": "2019-10-17T22:02:28.370Z",
"file": "D:\\a\\1\\s\\change\\react-native-windows-extended-2019-10-17-22-02-28-auto-update-versions060.0microsoft.8.json"
}
2 changes: 1 addition & 1 deletion current/ReactWindows/ChakraBridge/ChakraBridge.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<AppContainerApplication>true</AppContainerApplication>
<ApplicationType>Windows Store</ApplicationType>
<WindowsTargetPlatformVersion>10.0.18362.0</WindowsTargetPlatformVersion>
<WindowsTargetPlatformMinVersion>10.0.10240.0</WindowsTargetPlatformMinVersion>
<WindowsTargetPlatformMinVersion>10.0.18362.0</WindowsTargetPlatformMinVersion>
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
Expand Down
3 changes: 2 additions & 1 deletion vnext/stubs/double-conversion/double-conversion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ class DoubleToStringConverter {
s->m_ss << d;
}

bool ToExponential(double value, int requested_digits, StringBuilder *s) const {
bool ToExponential(double value, int /*requested_digits*/, StringBuilder *s)
const {
s->m_ss << value;
if (s->m_ss.fail()) {
s->m_ss.clear();
Expand Down