Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react version #4734

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Update react version #4734

merged 2 commits into from
Apr 28, 2020

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Apr 28, 2020

We updated react-native to 0.62.2 (which has a peer dependency of react 16.11.0), but our react version is still on 16.9.0, updating to 16.11.0.

Microsoft Reviewers: Open in CodeFlow

@kaiguo kaiguo requested a review from a team as a code owner April 28, 2020 03:33
@NickGerleman
Copy link
Collaborator

Thanks for catching this!

@kaiguo kaiguo merged commit ccbd12b into microsoft:master Apr 28, 2020
@kaiguo kaiguo deleted the update-react-version branch April 28, 2020 17:00
NickGerleman added a commit to NickGerleman/react-native-windows that referenced this pull request Apr 30, 2020
1. Use looser peer dependencies on React Native. 0.61 specified 0.61.5 explicitly, but based on recent discussion we want to allow patch releases of RN to work on any RNW version. Allow prerelease versions as well for any special forks, etc.

2. Fixup React Version everywhere. I missed upgraded React dependencies during the 0.62 upgrade. This was fixed in vnext and e2etest with microsoft#4734 but other packages were not updated. Update everything here.
NickGerleman added a commit that referenced this pull request Apr 30, 2020
* Package Fixes

1. Use looser peer dependencies on React Native. 0.61 specified 0.61.5 explicitly, but based on recent discussion we want to allow patch releases of RN to work on any RNW version. Allow prerelease versions as well for any special forks, etc.

2. Fixup React Version everywhere. I missed upgraded React dependencies during the 0.62 upgrade. This was fixed in vnext and e2etest with #4734 but other packages were not updated. Update everything here.

* Change files
NickGerleman pushed a commit to NickGerleman/react-native-windows that referenced this pull request May 2, 2020
* Update react version

* Change files
NickGerleman added a commit to NickGerleman/react-native-windows that referenced this pull request May 2, 2020
* Package Fixes

1. Use looser peer dependencies on React Native. 0.61 specified 0.61.5 explicitly, but based on recent discussion we want to allow patch releases of RN to work on any RNW version. Allow prerelease versions as well for any special forks, etc.

2. Fixup React Version everywhere. I missed upgraded React dependencies during the 0.62 upgrade. This was fixed in vnext and e2etest with microsoft#4734 but other packages were not updated. Update everything here.

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants