Fixes for bundle loading and back handler crash using xaml islands #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asklar
reviewed
May 15, 2020
asklar
reviewed
May 15, 2020
| @@ -15,11 +15,16 @@ | |||
| #define NOGDI | |||
| #endif | |||
|
|
|||
| #undef WINAPI_FAMILY | |||
| #define WINAPI_FAMILY WINAPI_FAMILY_DESKTOP_APP | |||
There was a problem hiding this comment.
make sure XBOX team isn't impacted
asklar
approved these changes
May 15, 2020
NickGerleman
approved these changes
May 16, 2020
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 2 hours 41 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
merged commit
NickGerleman
pushed a commit
to NickGerleman/react-native-windows
that referenced
this pull request
May 19, 2020
…icrosoft#4919) * Fixes for bundle loading and back handler crash using xaml islands * Change files * formatting * missed a change * Build fix for ReactUWP.
NickGerleman
pushed a commit
that referenced
this pull request
May 19, 2020
…4919) * Fixes for bundle loading and back handler crash using xaml islands * Change files * formatting * missed a change * Build fix for ReactUWP.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #4895 for just the platform fixes needed for XAML islands (that should also be included in 0.62)
One is a fix to allow the bundle path to be a file path rather than just a ms-appx path.
The 2nd is code to avoid a crash when calling into SystemNavigationManager when running from a Xaml island.
Microsoft Reviewers: Open in CodeFlow