Add support for 0..n args in native module callbacks #4929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
requested review from
dannyvv,
acoates-ms,
aeulitz,
ZihanChen-MSFT and
a team
NickGerleman
approved these changes
May 18, 2020
vmoroz
added
the
AutoMerge
|
Hello @vmoroz! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
NickGerleman
pushed a commit
to NickGerleman/react-native-windows
that referenced
this pull request
May 19, 2020
* Support 0..n args in native module callbacks * Change files
NickGerleman
pushed a commit
that referenced
this pull request
May 19, 2020
* Support 0..n args in native module callbacks * Change files
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is related to the issue #4789.
In our C# native module implementation we previously supported callbacks with only one argument in native modules. The C++ native modules already support callbacks with 0..n arguments.
In this PR we:
Microsoft Reviewers: Open in CodeFlow