Reduce the changes in our custom metro config #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
May 18, 2020
acoates-ms
added
Backport to 0.62
AutoMerge
|
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 7 hours 14 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
NickGerleman
pushed a commit
to NickGerleman/react-native-windows
that referenced
this pull request
May 19, 2020
* Reduce need for custom metro configs * Change files * Fix for integration tests
NickGerleman
pushed a commit
that referenced
this pull request
May 19, 2020
* Reduce need for custom metro configs * Change files * Fix for integration tests
jonthysell
added
the
Breaking Change
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of the CLI has been published which included my fix for supporting out of tree platforms.
This allows us to stop specifying custom resolveRequest, getModulesRunBeforeMainModule and assetRegistryPath settings in our metro configs.
We should consider porting this to 0.62. The downside is that if they updated to 0.62 earlier, their lock file will probably be pointing to an older version of the CLI which wont support the new react-native.config.js. -- Hopefully this is something we can document in some troubleshooting section of the docs or something.
Microsoft Reviewers: Open in CodeFlow