Make native modules to use JS queue #6284
Conversation
vmoroz
added
the
Breaking Change
|
Will this also apply to viewmanagers? If so we'd probably have to audit all of them to ensure they jump to the UI thread for UI operations.... |
|
UIManager posts most of its methods to the UIThread. By the time it gets to the ViewManager most things are UI thread. There is an exception on some of the view config constants that might be called from the JS thread. |
vmoroz
added
the
AutoMerge
|
Hello @vmoroz! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 8 hours 4 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
Removing "backport approved" label. After some internal discussions, we decided not to backport this one as it is a breaking change. |
* Make native modules to use JS queue * Change files
Surprisingly, we had a bug that all NativeModules 2.0 use UI queue to run their code. We call NativeModules 2.0 the native modules that run on top of the ABI safe API in the ReactNative for Windows.
In this change we switch them to use the JS queue as it supposed to be.
Microsoft Reviewers: Open in CodeFlow