Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolution for axios@^0.21.1 to pass CG #6810

Merged
merged 1 commit into from Jan 4, 2021
Merged

Add resolution for axios@^0.21.1 to pass CG #6810

merged 1 commit into from Jan 4, 2021

Conversation

jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Jan 4, 2021 •
edited

Appium support brings in axios. Appium support has updated to ^0.21.1 in their master, but have not published the fix.

We can remove this resolution if we remove Appium.

Closes #6702

Microsoft Reviewers: Open in CodeFlow

@jonthysell jonthysell added security Pull requests that address a security vulnerability Request Backport to 0.64 labels Jan 4, 2021
@jonthysell jonthysell requested a review from a team as a code owner January 4, 2021 18:07
NickGerleman
NickGerleman approved these changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@NickGerleman NickGerleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will get removed with Appium (which seems to be giving us a lot of these issues 😥). Lgtm, but would appreciate if we could have details in the PR about the deps bringing them in, since resolutions are a bit dangerous.

@jonthysell jonthysell merged commit a69ae29 into microsoft:master Jan 4, 2021
@jonthysell jonthysell deleted the axiosfix branch January 4, 2021 19:07
jonthysell added a commit to jonthysell/react-native-windows that referenced this pull request Jan 4, 2021
@jonthysell
Add resolution for axios@^0.21.1 to pass CG (microsoft#6810)
3701cae 
Appium support brings in axios. Appium support has updated to ^0.21.1 in their master, but have not published the fix.

We can remove this resolution if we remove Appium.

Closes microsoft#6702
@jonthysell jonthysell mentioned this pull request Jan 4, 2021
Merged
jonthysell added a commit that referenced this pull request Jan 4, 2021
@jonthysell
[0.64] Add resolution for axios@^0.21.1 to pass CG (#6810) (#6813)
9ae0c1e 
Backporting #6810 to 0.64.

Appium support brings in axios. Appium support has updated to ^0.21.1 in their master, but have not published the fix.

We can remove this resolution if we remove Appium.

Closes #6702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickGerleman NickGerleman NickGerleman approved these changes

Assignees
No one assigned
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component Governance fails due to axios@0.20.0
2 participants
@jonthysell @NickGerleman