[0.64] Bundle in solution dir (#6736) #6812
Conversation
* Specify full path when bundling * Change files * . * Change files * PR fb Co-authored-by: Alexander Sklar <asklar@winse.microsoft.com>
| <!-- Optional config file for the bundle command (metro will use metro.config.js by default) --> | ||
| <BundleConfigFile Condition="'$(BundleConfigFile)' == ''"></BundleConfigFile> | ||
|
|
||
| <FullOutDir Condition="'$([System.IO.Path]::GetFullPath($(OutDir)))' == '$(OutDir)'">$(OutDir)</FullOutDir> |
There was a problem hiding this comment.
Should the condition use IsPathRooted?
Technically there are many paths that are the same file but not identical, i.e. symlink expansions, long path prefix \\?\c:, old 8.3 paths progra~1 (even though I haven't seen this in a long time ;)) etc, etc
There was a problem hiding this comment.
Good question for @asklar who made the original change. This is just porting it to 0.64.
There was a problem hiding this comment.
sounds like a good idea, I wasn't aware of that method when I wrote this.
NickGerleman
added
the
AutoMerge
|
Hello @NickGerleman! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 7 hours 22 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Specify full path when bundling
Change files
.
Change files
PR fb
Co-authored-by: Alexander Sklar asklar@winse.microsoft.com
Microsoft Reviewers: Open in CodeFlow