Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable view managers to be notified about JS event handler attach/detach #7335

Merged
2 commits merged into from
Mar 10, 2021
Merged

Enable view managers to be notified about JS event handler attach/detach #7335

2 commits merged into from
Mar 10, 2021

Conversation

asklar
Copy link
Member

@asklar asklar commented Mar 9, 2021 •
edited by ghost

Fixes #7334

Microsoft Reviewers: Open in CodeFlow

@asklar asklar requested a review from a team as a code owner March 9, 2021 18:31
@asklar asklar mentioned this pull request Mar 9, 2021
Closed
@rozele
Copy link
Collaborator

rozele commented Mar 9, 2021

Doesn't this already work if you just write a native prop config with the registered event name and set the type to boolean? Certainly having prop type correctness for functions is better :)

@asklar
Copy link
Member Author

asklar commented Mar 9, 2021 •
edited

Doesn't this already work if you just write a native prop config with the registered event name and set the type to boolean? Certainly having prop type correctness for functions is better :)

@rozele
huh indeed that works! Totally undocumented though? :D Still it'd be nice to have the right type

@asklar asklar added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Mar 10, 2021
@ghost
Copy link

ghost commented Mar 10, 2021

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 0c64f4c into microsoft:master Mar 10, 2021
@asklar asklar deleted the notifyEventAttach branch March 10, 2021 06:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

Assignees
No one assigned
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View managers don't have a way to listen for JS event/detach
3 participants
@asklar @rozele @acoates-ms