Have script store return nullptr on facebook::jsi::JSINativeException #8068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikoAri
reviewed
Jun 21, 2021
JunielKatarn
added
the
AutoMerge
|
Hello @JunielKatarn! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
… mmap-catchjsiexc
ghost
merged commit
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jun 22, 2021
…microsoft#8068) * Return nullptr on facebook::jsi::JSINativeException * Change files * Remove unused exception name
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jun 22, 2021
…microsoft#8068) * Return nullptr on facebook::jsi::JSINativeException * Change files * Remove unused exception name
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jun 22, 2021
…microsoft#8068) * Return nullptr on facebook::jsi::JSINativeException * Change files * Remove unused exception name
This was referenced Jun 22, 2021
ghost
pushed a commit
that referenced
this pull request
Jun 22, 2021
* Create cswinrt projection nuget project * nuget package builds * use 1.3.0 and reunion 0.8 preview * publish artifact with reunion nupkg * Change files * > * > * > * > * > * > * > * > * > * > * > * > * > * > * > * split reunion into its own stage * > * > * > * > * > * > * 📦 Bump @types/chai from 4.2.18 to 4.2.19 (#8074) Bumps [@types/chai](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/chai) from 4.2.18 to 4.2.19. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/chai) --- updated-dependencies: - dependency-name: "@types/chai" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * >> * >> * >> * Block creating C# apps with Hermes (#8075) * Hermes cannot currently be used in C# apps, so blocking it in the CLI * Change files * Have script store return nullptr on facebook::jsi::JSINativeException (#8068) * Return nullptr on facebook::jsi::JSINativeException * Change files * Remove unused exception name * >>> * pr feedback * applying package updates ***NO_CI*** * 18362 * 19041 * >> * 📦 Bump @babel/preset-env from 7.14.5 to 7.14.7 (#8083) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.5 to 7.14.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 📦 Bump @babel/parser from 7.14.6 to 7.14.7 (#8082) Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.14.6 to 7.14.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-parser) --- updated-dependencies: - dependency-name: "@babel/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Tie visitAllPages Test to RNTesterList (#8071) * Tie visitAllPages Test to RNTesterList Fixes #7726 We have a UIA-based test which navigates back and forward from each RNTester example. The list of examples cannot be populated by the UI, and is currently hardcoded. The source of truth, RNTesterList in RNTester, loads quite a bit of RN with it. A previously discussed approach was to relay loaded data from the RN application process to the test runner. This change goes with a simpler approach, of making the test runner act more like RN. That includes Metro's Babel transformations, Windows platform resolution logic, and global setup. We can mostly rely on existing react-native UT infrastructure to automate most of this. This loads enough of the environment to allow successfully loading all RNTester example modules, letting us poke at its data. * remove extraneous export * Reduce synced typings surface * 📦 Bump @babel/traverse from 7.14.5 to 7.14.7 (#8081) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.14.5 to 7.14.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Pipeline (#8084) * Copy nuspec * Create cswinrt projection nuget project * nuget package builds * use 1.3.0 and reunion 0.8 preview * publish artifact with reunion nupkg * Change files * > * > * > * > * > * > * > * > * > * > * > * > * > * > * > * split reunion into its own stage * > * > * > * > * > * > * >> * >> * >> * >>> * pr feedback * 18362 * 19041 * >> * Copy nuspec Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julio César Rocha <JunielKatarn@users.noreply.github.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> Co-authored-by: Nick Gerleman <ngerlem@microsoft.com> Co-authored-by: dannyvv <dannyvv@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected error conditions such as prepared script cache not (yet) existing were not handled, crashing the host process.
This change returns
nullptron memory-mapped buffer creation for subsequent handling by the JS engine.Requesting backport to unblock Office feature.
Microsoft Reviewers: Open in CodeFlow