Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DisconnectFromView when the view is already disconnected #8220

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

asklar
Copy link
Member

@asklar asklar commented Jul 12, 2021

DisconnectFromView can be called on an view that has no connected tag.
Also fix exceptions to be thrown by value as the rest of the code expects them to be

Fixes #8219

Microsoft Reviewers: Open in CodeFlow

…. Also fix exceptions to be thrown by value as the rest of the code expects them to be
@asklar asklar requested a review from a team as a code owner July 12, 2021 03:44
@asklar asklar merged commit a7817e9 into microsoft:main Jul 12, 2021
@asklar asklar deleted the animatedNode branch July 12, 2021 20:45
asklar added a commit to asklar/react-native-windows that referenced this pull request Jul 12, 2021
…ft#8220)

* DisconnectFromView can be called on an view that has no connected tag. Also fix exceptions to be thrown by value as the rest of the code expects them to be

* Change files
asklar added a commit that referenced this pull request Jul 13, 2021
…8233)

* DisconnectFromView can be called on an view that has no connected tag. Also fix exceptions to be thrown by value as the rest of the code expects them to be

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in JS engine when using react-navigation
2 participants