Migrate NapiJsiRuntime from V8-JSI #8617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudorms
reviewed
Sep 13, 2021
vmoroz
reviewed
Sep 13, 2021
ghost
added
the
Needs: Author Feedback
vmoroz
reviewed
Sep 13, 2021
vmoroz
reviewed
Sep 13, 2021
vmoroz
reviewed
Sep 13, 2021
|
Please make sure that we run the JSI tests for the new code. |
ghost
removed
the
Needs: Author Feedback
ghost
merged commit 
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Sep 20, 2021
* Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com>
1 task
JunielKatarn
added a commit
that referenced
this pull request
Sep 21, 2021
This was referenced Sep 21, 2021
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Sep 21, 2021
* Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com>
1 task
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Sep 21, 2021
* Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com>
1 task
chrisglein
pushed a commit
to chrisglein/react-native-windows
that referenced
this pull request
Sep 22, 2021
* Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com>
JunielKatarn
added a commit
that referenced
this pull request
Sep 23, 2021
* Migrate NapiJsiRuntime from V8-JSI (#8617) * Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com> * Remove backported change file * Change files Co-authored-by: dannyvv <dannyvv@microsoft.com>
JunielKatarn
added a commit
that referenced
this pull request
Sep 23, 2021
* Migrate NapiJsiRuntime from V8-JSI #8617 * Change files * Drop HermesSamplingProfiler.cpp
JunielKatarn
added a commit
that referenced
this pull request
Sep 23, 2021
* Migrate NapiJsiRuntime from V8-JSI (#8617) * Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com> * Change files * Set V8/JSI version to 0.64.24 * Drop HermesSamplingProfiler.cpp and InspectorPackagerConnection.cpp * Update to older facebook::jsi::Runtime Co-authored-by: dannyvv <dannyvv@microsoft.com>
ghost
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Migrate NapiJsiRuntime from V8-JSI (#8617) * Add NapiJsiRuntime source and headers * Implement up to NapiJsiRuntime::JsiHostFunctionCallback * Change files * Finished Shared NAPI wrappers * Implemented miscellaneous utility methods * Move macros into CPP * yarn format * Add TODO to rename MakeNapiJsiRuntime2 * Fix typo * Consume MakeNapiJsiRuntime2 * Conditionally build NapiJsiRuntime.cpp * Migrate test * Move declarations into NapiJsiRuntime.cpp * Delete NapiJsiRuntime_detail.h * Re-enable NAPI_EXPERIMENTAL * Added :NapiPointerValue definitions * Use explicit captures * Add export symbol for x86 * Ensure CreateExternalObject deletes scalars and arrays properly * Use constants for RefHolder names * Only run test if USE_V8 is defined * Rename NapiTests to JsiTests * Conditionally include Jsi Tests * Rename MakeNapiJsiRuntime2 to MakeNodeApiJsiRuntime Co-authored-by: dannyvv <dannyvv@microsoft.com> * Move Shared\NapiJsiRuntime.* to MSRN.Cxx\NodeApiJsiRuntime.* * Move JsiTest into MSRN.Cxx.UnitTests * clang format * Revert ABITests.vcxproj to main * Default Cxx.UnitTests to NOT use V8 * Compile JsiTest only when using V8 Co-authored-by: dannyvv <dannyvv@microsoft.com> * Change files * Update to older facebook::jsi::Runtime Co-authored-by: dannyvv <dannyvv@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the implementation of MakeNapiJsiRuntime from V8-JSI into React Native Windows.
Motivation
MakeNapiJsiRuntime exposes non-ABI-safe C++ JSI APIs.
Thus, it should not reside in the V8-JSI DLL boundary.
As an intermediate measure, moving such method and supporting types into RNW.
Pre-merge Checklist
Microsoft Reviewers: Open in CodeFlow