Re-implemented wpf shadow #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Bonus: automatically works with transparent images: |
matthargett
suggested changes
Feb 10, 2017
| [ReactProp(ViewProps.ShadowColor, CustomType = "Color")] | ||
| public void SetShadowColor(TFrameworkElement view, uint? color) | ||
| { | ||
| DropShadowEffect effect = (DropShadowEffect)view.Effect ?? new DropShadowEffect(); |
| [ReactProp(ViewProps.ShadowOpacity)] | ||
| public void SetShadowOpacity(TFrameworkElement view, double opacity) | ||
| { | ||
| DropShadowEffect effect = (DropShadowEffect)view.Effect ?? new DropShadowEffect(); |
| [ReactProp(ViewProps.ShadowRadius)] | ||
| public void SetShadowRadius(TFrameworkElement view, double radius) | ||
| { | ||
| DropShadowEffect effect = (DropShadowEffect)view.Effect ?? new DropShadowEffect(); |
| [ReactProp(ViewProps.ShadowOffset)] | ||
| public void SetShadowOffset(TFrameworkElement view, JObject offset) | ||
| { | ||
| DropShadowEffect effect = (DropShadowEffect)view.Effect ?? new DropShadowEffect(); |
rozele
reviewed
Feb 10, 2017
| DropShadowEffect effect = (DropShadowEffect)view.Effect ?? new DropShadowEffect(); | ||
| var deltaX = offset.Value<double>("width"); | ||
| var deltaY = offset.Value<double>("height"); | ||
| var angle = Math.Atan2(deltaY, deltaX) * (180 / Math.PI); |
There was a problem hiding this comment.
180 [](start = 54, length = 3)
I'm pretty sure this returns a double anyway, but it may make sense to use 180.
rozele
reviewed
Feb 10, 2017
| @@ -84,6 +84,11 @@ public static class ViewProps | |||
| public const string BorderBottomLeftRadius = "borderBottomLeftRadius"; | |||
| public const string BorderBottomRightRadius = "borderBottomRightRadius"; | |||
|
|
|||
| public const string ShadowColor = "shadowColor"; | |||
| public const string ShadowOffset = "shadowOffset"; | |||
There was a problem hiding this comment.
Can we just inline the strings? I try to keep tis file in sync with https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.java. I should have put a comment along those lines in here.
rozele
pushed a commit
that referenced
this pull request
Feb 10, 2017
* re-implemented wpf shadow * Addressing minor comments from review.
rozele
pushed a commit
that referenced
this pull request
Feb 15, 2017
* re-implemented wpf shadow * Addressing minor comments from review.
rozele
pushed a commit
that referenced
this pull request
Feb 15, 2017
* re-implemented wpf shadow * Addressing minor comments from review.
|
It not working |
|
This is very outdated code, I wouldn't expect it to work anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UWP implementation will have to be totally different, but for now this addresses the WPF side of #953