Add target to optionally run CodeGen before ReactNativeXaml build #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some new MSBuild properties and targets within ReactNativeXaml.vcxproj to support re-running the CodeGen before the build. By setting a property in their ExperimentalFeatures.props file: ```xml <RunReactNativeXamlCodeGenBeforeBuild>true</RunReactNativeXamlCodeGenBeforeBuild> ``` Customers can make sure the CodeGen tool runs before the native build. It's default to `false` since most customers don't need it. However, this will hopefully address microsoft/react-native-windows#10792, which was a hack to get the same effect. Note that customers can also customize how the CodeGen runs, in particular, by specifying a different `ReactNativeXamlTargetWinMD` file if desired.
|
This works as-is, however it works better in combination with #232. Looking to see if it's worth enhancing the target with the proper inputs/outputs so it's not run unnecessarily, and so can be set to run by default. |
|
Will merge main into this when #232 is checked in. |
asklar
reviewed
Nov 3, 2022
asklar
reviewed
Nov 3, 2022
asklar
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new MSBuild properties and targets within ReactNativeXaml.vcxproj to support re-running the CodeGen before the build.
By setting a property in their ExperimentalFeatures.props file:
Customers can make sure the CodeGen tool runs before the native build. It's default to
falsesince most customers don't need it. However, this will hopefully address microsoft/react-native-windows#10792, which was a hack to get the same effect.Note that customers can also customize how the CodeGen runs, in particular, by specifying a different
ReactNativeXamlTargetWinMDfile if desired.Microsoft Reviewers: Open in CodeFlow