Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DataFrameDirectory and ModelDirectory to AnyDirectory. #1115

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

weedqian
Copy link
Contributor

@weedqian weedqian commented Jun 2, 2020

Description

Currently, SAR modules use DataFrameDirectory and ModelDirectory as port type which are registered by Designer when users opening the Designer pages.

However, there are some customers use modules with SDK or use the Basic AML workspace only. They would get blocked by the port types.
So, we change the DataFrameDirectory and ModelDirectory to AnyDirectory, which is a default port type in AML Workspace to let users to try these modules more easily.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgfierro miguelgfierro merged commit 28920bf into recommenders-team:staging Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants