Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ediit READMEs based on Simon's feedback; sync dependencies in conda script #1515

Merged
merged 9 commits into from
Sep 7, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Sep 1, 2021

Description

  • Made edits according to Simon's suggestions
  • One of the suggestions was to sync dependencies in generate_conda_file.py with setup.py
  • Part of the edits was instructions for conda and Python 3.7.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@laserprec
Copy link
Contributor

laserprec commented Sep 1, 2021

image
I think the code coverage decrease is not due to any changes in this PR. Please disregard if anyone is concerned about this. Please see below you want to know the details 😄:

Currently we have two pipelines running two slightly different tests: the pr-gate that runs only the unit tests and the code coverage is around 62% and the nightly build that runs the full tests suites: unit, smoke and integration tests. The coverage is around 74%. My last PR involved adding the nightly build so the PR runs the full nightly build and remembers the higher coverage number instead. This is a special occasion, and I don't think this inaccurate code coverage would recur once we bury the staging branch with more commits.

@laserprec laserprec mentioned this pull request Sep 2, 2021
4 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1515 (86e500c) into staging (c5029af) will decrease coverage by 12.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           staging    #1515       +/-   ##
============================================
- Coverage    74.23%   62.02%   -12.22%     
============================================
  Files           84       84               
  Lines         8369     8369               
============================================
- Hits          6213     5191     -1022     
- Misses        2156     3178     +1022     
Impacted Files Coverage Δ
...ecommenders/models/newsrec/io/mind_all_iterator.py 12.21% <0.00%> (-86.65%) ⬇️
recommenders/models/newsrec/io/mind_iterator.py 15.67% <0.00%> (-82.71%) ⬇️
...ommenders/models/deeprec/io/sequential_iterator.py 15.85% <0.00%> (-81.94%) ⬇️
recommenders/models/newsrec/models/base_model.py 30.90% <0.00%> (-59.40%) ⬇️
...deeprec/models/sequential/sequential_base_model.py 46.97% <0.00%> (-47.66%) ⬇️
recommenders/models/geoimc/geoimc_data.py 41.66% <0.00%> (-44.80%) ⬇️
...enders/models/deeprec/io/dkn_item2item_iterator.py 45.61% <0.00%> (-42.11%) ⬇️
...menders/models/deeprec/models/graphrec/lightgcn.py 51.47% <0.00%> (-40.24%) ⬇️
recommenders/datasets/mind.py 0.00% <0.00%> (-30.85%) ⬇️
recommenders/datasets/movielens.py 76.96% <0.00%> (-14.05%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5029af...86e500c. Read the comment docs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +35 to +39
databricks_cli>=0.8.6,<1
pyarrow>=0.8.0,<1.0.0
pyspark>=2.4.5,<3.0.0
cmake>=3.18.4.post1
xlearn==0.40a1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this is merged to staging a new doc is going to be generated. I'm not sure if pyspark dep is going to break the docs, let's see how it goes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the compilation of docs and it seems to work.

@anargyri anargyri merged commit 4ab2e9c into staging Sep 7, 2021
@anargyri anargyri deleted the andreas/simon_feedback branch September 7, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants