Support ReactRedux 6 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o abettadapur/react-redux-6
navneet-g
reviewed
Nov 12, 2018
| const store: IModuleStore<any> = context.store; | ||
| if (!store) { | ||
| throw new Error("Could not load store from React context."); | ||
| if (!ReactReduxContext) { |
There was a problem hiding this comment.
if (!ReactReduxContext && !context.store) {
throw new Error("Could not load store from React context.");
}
navneet-g
reviewed
Nov 12, 2018
| <ReactReduxContext.Consumer> | ||
| {(context) => ( | ||
| <DynamicModuleLoaderImpl | ||
| store={context.store} |
There was a problem hiding this comment.
Do we need to assert here that context.store is not null?
navneet-g
reviewed
Nov 12, 2018
| @@ -6,11 +6,16 @@ import { | |||
| IDynamicallyAddedModule | |||
| } from "./Contracts"; | |||
|
|
|||
| // @ts-ignore | |||
There was a problem hiding this comment.
Needed, because the context is not used
|
@navneet-g Can you review this once more? |
navneet-g
reviewed
Dec 21, 2018
lerna.json
Outdated
| @@ -2,5 +2,6 @@ | |||
| "packages": [ | |||
| "packages/*" | |||
| ], | |||
| "hoist": true, | |||
navneet-g
reviewed
Dec 21, 2018
| /** Modules that need to be dynamically registerd */ | ||
| modules: IModule<any>[]; | ||
|
|
||
| store: IModuleStore<any>; |
There was a problem hiding this comment.
store?: IModuleStore<any>;
To explicity state that store can be undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27