Seed reducers after adding them #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add tests for this scenario |
navneet-g
approved these changes
May 1, 2019
| @@ -26,6 +26,10 @@ export function getModuleManager<State>( | |||
| let _modules: IModule<any>[] = []; | |||
| const _moduleIds = new Set(); | |||
|
|
|||
| const _seedReducers = () => { | |||
| _dispatch({ type: "@@Internal/ModuleManager/SeedReducers" }); | |||
There was a problem hiding this comment.
Please add some comments on the scenario on why this is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When reducers were added, we did not dispatch an action to seed them with initial state. This meant that the initial state was not available to any of the extensions of the module.
Fix:
Seed the reducers by firing an action after adding them