Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] 1.Error analysis tree node text alignment 2. Add ariaLabel for new cohort panel 3. Model overview chart fix #1719

Merged
merged 4 commits into from Sep 14, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Sep 14, 2022

Signed-off-by: Ruby Zhu zhenzhu@microsoft.com

Description

  1. Fix error analysis tree node text alignment
    Before fix
    image

After fix
image

  1. Add aria-label for New Cohort panel

  2. For model overview probability distribution and metrics visualizations, move choose cohorts button above charts.
    Fix choose metric button reflow issue, it got truncated in small screen
    Before fix
    the choose cohorts button is on the left
    image
    image
    the choose cohorts button is above the chart
    image

After fix
the choose cohorts button is above chart for all three scenarios
image
image
image

Before fix - 320*256 resolution
The choose cohorts button is gone and choose label button is not fully visible
Same issue for metrics visualizations
probDisB
After fix
probDisA

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1719 (ddabf44) into main (40108ea) will decrease coverage by 3.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   89.00%   85.45%   -3.56%     
==========================================
  Files         105       58      -47     
  Lines        5577     3032    -2545     
==========================================
- Hits         4964     2591    -2373     
+ Misses        613      441     -172     
Flag Coverage Δ
unittests 85.45% <ø> (-3.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponsibleai/databalanceanalysis/balance_measures.py
...sponsibleai/responsibleai/managers/base_manager.py
...sibleai/responsibleai/rai_insights/rai_insights.py
.../databalanceanalysis/aggregate_balance_measures.py
...ponsibleai/responsibleai/rai_insights/constants.py
...leai/responsibleai/modelanalysis/model_analysis.py
...tabalanceanalysis/distribution_balance_measures.py
...ai/responsibleai/_tools/error_analysis/__init__.py
...ai/responsibleai/rai_insights/rai_base_insights.py
...ai/responsibleai/_tools/counterfactual/__init__.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

2 similar comments
@RubyZ10 RubyZ10 enabled auto-merge (squash) September 14, 2022 23:01
@RubyZ10 RubyZ10 merged commit d8f172a into main Sep 14, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/accessibility branch September 14, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants