[Refactor] Add preBuiltCohort to datasetCohorts in modelAssessmentContext #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
RubyZ10
changed the title
RubyZ10
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
vinuthakaranth,
romanlutz and
hawestra
as code owners
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/ProcessPreBuiltDatasetCohort.ts
Outdated
Show resolved
Hide resolved
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/ProcessPreBuiltDatasetCohort.ts
Outdated
Show resolved
Hide resolved
…ProcessPreBuiltDatasetCohort.ts Co-authored-by: Ilya Matiach <ilmat@microsoft.com>
…ProcessPreBuiltDatasetCohort.ts Co-authored-by: Ilya Matiach <ilmat@microsoft.com>
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/ProcessPreBuiltDatasetCohort.ts
Show resolved
Hide resolved
imatiach-msft
approved these changes
Mar 15, 2023
1 similar comment
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
tongyu-microsoft
approved these changes
Apr 5, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added preBuiltCohort to datasetCohorts and added datasetCohorts into modelAssessmentContext
for example, in below screenshots the arg has the actual feature value, but in datasetCohort filter, it is storing the index of those feature values, so we need to translate the arg.
FYI, The filter format of DatasetCohort is the same as what SDK expected when calling from UI. in below screen shots it is a actual call from UI to SDK, column "Programming language" is a categorical feature, and the arg is passing the index of selected values. this is exactly the same as DatasetCohort filter.
Checklist