Add validations if target column is included in FeatureMetadata
#2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2013 +/- ##
==========================================
- Coverage 93.07% 92.36% -0.71%
==========================================
Files 48 95 +47
Lines 1963 4899 +2936
==========================================
+ Hits 1827 4525 +2698
- Misses 136 374 +238
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hawestra
approved these changes
Mar 28, 2023
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
imatiach-msft
approved these changes
Mar 29, 2023
gaugup
deleted the
gaugup/AddValidationsIfTargetIncludedInFeatureMetadata
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validations if target column is included in
FeatureMetadata. If we don't do this validation a downstream validation (predict validation) will fail with cryptic errors.Checklist