Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EBM and LightGBM with TreeShap methods to calculate error correlation in error analysis #2018

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

imatiach-msft
Copy link
Contributor

Description

Allow users to select EBM or LightGBM with TreeShap for the error correlation scores in the feature list panel.
Users will now be able to specify the error_correlation_method parameter, set by default to mutual_info, to be set to ebm or gbm_shap to allow them to compute the error correlations (or feature importances with respect to errors) via the new methods.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

1 similar comment
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #2018 (5092b98) into main (04204d2) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
+ Coverage   92.32%   92.34%   +0.01%     
==========================================
  Files          95       98       +3     
  Lines        4902     4949      +47     
==========================================
+ Hits         4526     4570      +44     
- Misses        376      379       +3     
Flag Coverage Δ
unittests 92.34% <94.73%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sis/erroranalysis/error_correlation_methods/ebm.py 81.25% <81.25%> (ø)
erroranalysis/erroranalysis/_internal/constants.py 100.00% <100.00%> (ø)
...ranalysis/erroranalysis/analyzer/error_analyzer.py 95.62% <100.00%> (+0.14%) ⬆️
...rroranalysis/error_correlation_methods/__init__.py 100.00% <100.00%> (ø)
...sis/erroranalysis/error_correlation_methods/gbm.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit af5f4a1 into main Apr 20, 2023
@imatiach-msft imatiach-msft deleted the ilmat/ea-feat-imp branch April 20, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants