Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing builds by upgrading pip-tools after latest pip release #2038

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Apr 19, 2023

Description

Latest builds are failing with error:

in get_dependencies
    wheel_cache = WheelCache(self._cache_dir, self.options.format_control)
TypeError: __init__() takes 2 positional arguments but 3 were given

The latest pip release broke compatibility with old pip-tools. Solution seems to be to upgrade pip-tools since we are pinned to an old version currently.

See related issue: jazzband/pip-tools#1823

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Copy link
Contributor

@gaugup gaugup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Invalid value for '[SRC_FILES]...': Path 'requirements-dev-comp.txt' does not exist.

it looks like it is running into problem with file not found error.

1 similar comment
@imatiach-msft
Copy link
Contributor Author

Error: Invalid value for '[SRC_FILES]...': Path 'requirements-dev-comp.txt' does not exist.

it looks like it is running into problem with file not found error.

yes I was missing a -o argument it looks like

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #2038 (79cbff0) into main (e697341) will decrease coverage by 0.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2038      +/-   ##
==========================================
- Coverage   93.06%   92.32%   -0.74%     
==========================================
  Files          48       95      +47     
  Lines        1962     4902    +2940     
==========================================
+ Hits         1826     4526    +2700     
- Misses        136      376     +240     
Flag Coverage Δ
unittests 92.32% <ø> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft
Copy link
Contributor Author

seems it is all working now with latest changes

1 similar comment
@imatiach-msft imatiach-msft merged commit 04204d2 into main Apr 20, 2023
139 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-builds-pip branch April 20, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants