Fix bugs 1.Save and switch doesn't do anything in cohort edit panel 2.Unable to edit cohort filters in certain scenario #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyZ10
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
vinuthakaranth,
romanlutz and
hawestra
as code owners
RubyZ10
changed the title
imatiach-msft
approved these changes
Apr 21, 2023
hawestra
approved these changes
Apr 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Fix Save and switch doesn't do anything in cohort edit panel
Before fix
After save and switch the main dashboard still stays with All cohort
After fix
After save and switch main dashboard switch to the new cohort
2. Fix Unable to edit cohort filters in certain scenario
Before fix
After fix
Checklist