Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CD.yml permissions errors for dashboard links on PRs #2525

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Feb 2, 2024

Description

fix CD.yml permissions errors for dashboard links on PRs

As of Feb 1, 2024, permissions are set as read-only by default for github actions based on the alert:

image

For more details, please see:
https://docs.opensource.microsoft.com/github/apps/permission-changes/#what-steps-must-i-take-to-avoid-a-bad-time

Due to this change, we now see errors like the following on main:

image

For example failing build output see:
https://github.com/microsoft/responsible-ai-toolbox/actions/runs/7758629239/job/21164158648?pr=2522

To fix our broken CD.yml builds, this PR gives write permissions for PRs.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft merged commit ff00051 into main Feb 2, 2024
60 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-ci-permissions branch February 2, 2024 19:37
@jamesbchao jamesbchao mentioned this pull request Feb 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants